dws2jgf: fix node attributes #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshcorbett
force-pushed
the
dws2jgf-fix-attributes
branch
from
3ca545f
to
464d186
Compare
Problem: flux-dws2jgf writes out vertex properties as a python list, but Fluxion's JGF reader expects a JSON object. Write out properties as keys in a mapping with empty string values. Some properties are still written out as a list, because they are written out by Fluxion code. When Fluxion updates to write them out correctly, the tests will need to be updated again. However, at the moment they do not cause any errors.
Problem: there are no tests to ensure that flux-dws2jgf handles the encoding of properties correctly. Add a test and change the expected type of properties from a JSON list to an object.
jameshcorbett
force-pushed
the
dws2jgf-fix-attributes
branch
from
464d186
to
3c73a7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: flux-dws2jgf writes out vertex properties as a python list,
but Fluxion's JGF reader expects a JSON object.
Write out properties as keys in a mapping with empty string values.
See also flux-framework/flux-sched#1149.