Skip to content

Commit

Permalink
flux-exec: ignore error on zhashx_freefn()
Browse files Browse the repository at this point in the history
Problem: zhashx_freefn() only returns an error on an invalid
hash entry.  However, we know a successful insert just occurred
so we don't have to check for an error.

Ignore return value from zhashx_freefn().
  • Loading branch information
chu11 committed May 31, 2023
1 parent 075578d commit e3fdf2a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/cmd/flux-exec.c
Expand Up @@ -117,8 +117,7 @@ void completion_cb (flux_subprocess_t *p)
if (!(idset = idset_create (rank_range, 0)))
log_err_exit ("idset_create");
(void)zhashx_insert (exitsets, buf, idset);
if (!zhashx_freefn (exitsets, buf, idset_destroy_wrapper))
log_err_exit ("zhashx_freefn");
(void)zhashx_freefn (exitsets, buf, idset_destroy_wrapper);
}

if (idset_set (idset, rank) < 0)
Expand Down

0 comments on commit e3fdf2a

Please sign in to comment.