kvs: check that fence parameters are identical #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1329 +/- ##
==========================================
+ Coverage 78.22% 78.23% +0.01%
==========================================
Files 156 156
Lines 28315 28321 +6
==========================================
+ Hits 22150 22158 +8
+ Misses 6165 6163 -2
|
|
Thanks, with bonus test even! Needs a rebase. |
Previously, fences could be updated with new flags. Instead, require users to always specify the same nprocs and flags with each fence request. Return error if user does not. Fixes flux-framework#1305
Add test to ensure fence captures an invalid flag/nproc value.
|
rebased and pushed. Also added a commit that fixes one lingering "namespace" -> "name_space", as was done in #1327. |
|
Restarted a builder that failed here, a recurrence of #1077 |
|
Restarted another one that hung, last message was: |
|
That last one is #1311. Valgrind is taking too long, doesn't output anything, and eventually the 10 minutes is up. |
|
OK, merging this - thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1305, as fence documentation and kvs server behavior did not match. IMO, the documentation indicated what the appropriate behavior should be, so code was adjusted to match it, and unit tests added.