You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
that the wait-event was sort of pointless. Earlier in the t2202 set of tests another exception was created in the same job (in job-manager: raise non-fatal exception on job). So the wait-event returns after seeing the prior exception, not the "cancel" exception.
Was simply going to fix up this test by not reusing the job id, but I realized that this was a legitimate test case. We want to cancel a job that has already had several exceptions in it, but wait specifically for the cancellation.
Perhaps, wait-event should have options to wait on portions from the context?
The text was updated successfully, but these errors were encountered:
Perhaps, should wait-event have options to wait on portions from the context?
Yeah, I was thinking the same thing earlier. The interface for allowing that kind of matching might need a little design work though.
It also might be useful to eventually allow more complex event matching as well, for instance you may want to wait for a "finish" or "exception" event.
Add --match-context option to wait-event, allowing user to check
for an arbitrary key=value in the context of an event.
Add new tests.
Fixesflux-framework#2083
I noticed in this test
that the
wait-event
was sort of pointless. Earlier in the t2202 set of tests another exception was created in the same job (injob-manager: raise non-fatal exception on job
). So thewait-event
returns after seeing the prior exception, not the "cancel" exception.Was simply going to fix up this test by not reusing the job id, but I realized that this was a legitimate test case. We want to cancel a job that has already had several exceptions in it, but wait specifically for the cancellation.
Perhaps,
wait-event
should have options to wait on portions from the context?The text was updated successfully, but these errors were encountered: