docker: update centos7 image to python3.6 and add valgrind-devel

[grondo]

Problem: without the valgrind-devel package, valgrind.h is not found
during configure and the valgrind test is disabled by default. When
run with -d, the t5000-valgrind.t is forced to run, but may encounter
false positives and bad stack traces due to modules that are dlclosed.

Add valgrind-devel to the centos7 docker image. (valgrind.h is part of
the base valgrind package in Ubuntu)

[grondo]

A new docker image for centos7 has been built and pushed up to dockerhub already.

[garlick]

Thanks! Probably should update the redhat column in README.md. It only lists the valgrind package right now.

[grondo]

Hm, maybe we need to separate build vs test requirements? It is kind of strange to list valgrind as a build requirement. And valgrind.h is really only required for test suite. (though I guess it is useful if someone wants to run valgrind on installed flux, so perhaps it is actually useful to list as a suggestion)

…

On Wed, Jul 10, 2019, 7:31 AM Jim Garlick ***@***.***> wrote: Thanks! Probably should update the redhat column in README.md. It only lists the valgrind package right now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2221?email_source=notifications&email_token=AAFVEUXCQCPCJ4CHNLJYVYTP6XXENA5CNFSM4H7P2NZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZTU2EQ#issuecomment-510086418>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFVEUUQOOGKX3ZGNXARXS3P6XXENANCNFSM4H7P2NZQ> .

[garlick]

There's a little annotation in there that it is an optional test requirement, FWIW.

[grondo]

Ah, ok! Sorry I didn't even actually check the list, duh.

I'll add a commit here to add valgrind-devel to the list for redhat. Thanks.

[grondo]

Hm, the updated centos7 image seems to have broken the python 3.4 build:

configure:14902: checking for cffi.__version_info__ >= (1,1) in python module cffi
Traceback (most recent call last):
  File "<string>", line 4, in <module>
ImportError: No module named 'cffi'
configure:14929: result: no
configure:14931: error: could not find python module cffi, version 1.1+ required

I'll see if I can fix this asap.

[grondo]

Oh, I forgot that RHEL7/centos7 had moved python3 from python3.4 to python3.6. By recreating the centos7 docker image I inadvertently updated to a version where we don't have required python3.4 packages.

On our TOSS systems we've also updated python3 to python3.6. I can try moving our Travis PYTHON_VERSION=3.4 tests to PYTHON_VERSION=3.6 if that is ok with @SteVwonder and @trws?

[SteVwonder]

On our TOSS systems we've also updated python3 to python3.6. I can try moving our Travis PYTHON_VERSION=3.4 tests to PYTHON_VERSION=3.6 if that is ok with @SteVwonder and @trws?

Works for me 😄

[grondo]

Ok, done (pushed new docker image to docker hub as well), and updated the title of this PR accordingly.

[garlick]

Thank you! Looks great to me.

[trws]

Sounds good to me, I don't think there's anything we need to be worried about there. Really we might even want to require 3.6 if a user wants to use 3 for a variety of reasons, but updating this should be no issue. Mark Grondona <notifications@github.com> writes:

…

Oh, I forgot that RHEL7/centos7 had moved python3 from python3.4 to python3.6. By recreating the centos7 docker image I inadvertently updated to a version where we don't have required python3.4 packages. On our TOSS systems we've also updated python3 to python3.6. I can try moving our Travis PYTHON_VERSION=3.4 tests to PYTHON_VERSION=3.6 if that is ok with @SteVwonder and @trws? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #2221 (comment)