mergify: fix rule that prevents merging of "WIP" PRs #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mergify rule that prevents PR titles from matching if they begin with WIP, wip, [WIP], or [wip] does not work due to the extra quotes around the regex. Remove the quotes so that the reverse match works.
Codecov Report
@@ Coverage Diff @@
## master #2453 +/- ##
=======================================
Coverage 81.11% 81.11%
=======================================
Files 225 225
Lines 36170 36170
=======================================
Hits 29340 29340
Misses 6830 6830
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally emailed mergify support to ask why our title match regex wasn't working, and it turned out the regex should not have been double-quoted.
Fixed and pushed in this small PR.