fix minor issues found by lgtm scan #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the global Lua state variable from `L` to `global_L` for clarity and to avoid warnings from lgtm scan about shadowing global variables.
garlick
approved these changes
Jan 5, 2020
src/common/libutil/cleanup.h
Outdated
| @@ -8,6 +8,9 @@ | |||
| * SPDX-License-Identifier: LGPL-3.0 | |||
| \************************************************************/ | |||
|
|
|||
| #ifndef HAVE_LIBUTIL_CLEANUP_H | |||
| #define HAVE_LIBUTIL_CLENAUP_H 1 | |||
There was a problem hiding this comment.
Ah, thanks. Force pushed a fix. I was kind of hoping lgtm scan would catch that sort of thing, but oh well.
Add header guard to src/common/libutil/cleanup.h as caught during lgtm scan.
Add header guard to src/common/libutil/mnemonic.h as detected by lgtm scan.
Add missing header guard to src/common/libutil/unlink_recursive.h as detected by lgtm scan.
Add missing header guard to src/cmd/builtin.h as detected by lgtm scan.
Add missing header guard to src/broker/content-cache.h as detected by lgtm scan.
Add missing header guard to src/common/libaggregate/aggregate.h as detected by lgtm scan.
Add missing header guard to src/broker/liblist.h as detected by lgtm scan.
Add missing header guard to src/common/libidset/idset_private.h as detected by lgtm scan.
Add missing header guard to src/broker/pmiutil.h as detected by lgtm scan.
Add missing header guard to src/common/libschedutil/schedutil_private.h as detected by lgtm scan.
Add missing header guard to src/shell/mpir/rangelist.h as detected by lgtm scan.
Ensure `errflag` bitfield in struct flux_reactor is an unsigned integer type. Detected by lgtm scan.
Ensure `blocked` bitfield in struct kvstx has unsigned type. Detected by lgtm scan.
Remove unused imports from t/job-manager/*.py as detected by lgtm scan.
Codecov Report
@@ Coverage Diff @@
## master #2605 +/- ##
==========================================
+ Coverage 81.43% 81.45% +0.02%
==========================================
Files 248 248
Lines 38495 38498 +3
==========================================
+ Hits 31348 31359 +11
+ Misses 7147 7139 -8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran across lgtm.com which was already scanning this project, and thought I'd just go ahead and fix some of the obvious errors it caught.
Overall, it seems like lgtm catches some valid (though simple) errors, and it might be nice to turn this service on for pull requests (free for open source projects), if that is ok.