job-manager: get jobspec from KVS on restart #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Restarted centos 7 builder that had hung in the "hydra launches flux" test. That might be the hang we've been seeing on centos 7. Anyway, thanks for the review - I'll set MWP. |
Problem: recent changes to cache jobspec in job manager neglected to restore jobspec when job manager is restarted. Look up jobspec in parallel with eventlog when replaying job eventlogs during job manager startup.
SteVwonder
force-pushed
the
restart_jobspec
branch
from
2b4b518
to
c0f02e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3396 +/- ##
==========================================
+ Coverage 81.93% 81.98% +0.04%
==========================================
Files 301 301
Lines 46445 46462 +17
==========================================
+ Hits 38055 38091 +36
+ Misses 8390 8371 -19
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: recent changes to cache jobspec in job manager
neglected to restore jobspec when job manager is restarted.
Look up jobspec in parallel with eventlog when replaying
job eventlogs during job manager startup.