libkvs: compact only if ops len > 1 #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
approved these changes
Aug 1, 2021
src/common/libkvs/kvs_txn_compact.c
Outdated
| @@ -210,7 +210,7 @@ int txn_compact (flux_kvs_txn_t *txn) | |||
| } | |||
|
|
|||
| len = json_array_size (txn->ops); | |||
| if (!len) | |||
| if (!(len > 1)) | |||
There was a problem hiding this comment.
Good catch!
Slightly odd comparison there - what about len < 2?
There was a problem hiding this comment.
haha,yeah I guess that would be simpler :-)
Problem: The txn_compact() function would attempt to compact transactions if there are > 0 operations. But it is impossible to compact just 1 operation, you need atleast 2 operations to conceivably compact. Solution: Check for > 1 instead of > 0 operations.
|
re-pushed per @garlick comment above. I'll set MWP after this passes. |
Codecov Report
@@ Coverage Diff @@
## master #3807 +/- ##
==========================================
- Coverage 83.35% 83.33% -0.02%
==========================================
Files 348 348
Lines 51014 51014
==========================================
- Hits 42521 42513 -8
- Misses 8493 8501 +8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this will doing some looking at issue #1804 awhile back. Forgot that I had this sitting on a branch. It's just a simple / dumb fix.