New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
job-manager: allow dependencies on completed jobs #4287
Comments
This seems like a good and relatively easy improvement to dependencies, so adding to the next milestone. It seems like rfc 26 does not place any restrictions on the antecedent job state when a simple job dependency is added, so this is actually required for a correct implementation? |
Yes, but RFC 26 describes the dependency specification and I don't think covers details of how dependencies are satisfied? But I agree it would be more correct and less surprising to fix this particular issue. (Though if there is an inactive job purge, I'm guessing the same problem could be introduced, so I would avoid explicitly requiring that any inactive job can be a antecedent...) |
Problem: Job manager plugins can now lookup inactive jobs via the flux_jobtap_job_lookup(3) function, but the dependency-after plugin does not properly handle jobs in the INACTIVE state. Add a check for a job state of INACTIVE in the dependency-after plugin, and attempt ot either resolve the depedency immediately or reject the job if the dependency is not satisfiable. Fixes flux-framework#4287
Problem: Job manager plugins can now lookup inactive jobs via the flux_jobtap_job_lookup(3) function, but the dependency-after plugin does not properly handle jobs in the INACTIVE state. Add a check for a job state of INACTIVE in the dependency-after plugin, and attempt ot either resolve the depedency immediately or reject the job if the dependency is not satisfiable. Fixes flux-framework#4287
Some other random thoughts:
Originally posted by @grondo in #4286 (comment)
The text was updated successfully, but these errors were encountered: