libsubprocess: avoid segfault on empty argv #4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: flux_local_exec() did not check if the user supplied any arguments for execution. This was not consistent to the checks supplied by flux_rexec() and can lead to a segfault internally. Solution: Add a argument count check identical to the check done in flux_rexec(). Add a unit test. Fixes flux-framework#4347
chu11
changed the title
|
title tweaked!, setting MWP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: flux_local_exec() did not check if the user supplied
any arguments for execution. This was not consistent to the
checks supplied by flux_rexec() and can lead to a segfault
internally.
Solution: Add a argument count check identical to the check done
in flux_rexec(). Add a unit test.
Fixes #4347