Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broker: content.flush does not force flush #4378

Closed
chu11 opened this issue Jun 21, 2022 · 1 comment
Closed

broker: content.flush does not force flush #4378

chu11 opened this issue Jun 21, 2022 · 1 comment
Assignees
@chu11

Comments

@chu11
Copy link
Member

chu11 commented Jun 21, 2022

While working on #4375 / #4376, it was determined that content.flush does not actually flush the cache. It only waits if any flushes are correctly ongoing to finish.

This is probably not what is desired, leads to issues, and runs counter to documentation of flux content flush
.
@chu11 chu11 changed the title broker: content.flush does not flush broker: content.flush does not force flush Jun 21, 2022
@chu11
Copy link
Member Author

chu11 commented Jun 21, 2022 •
edited

Note, I believe the core change was introduced in 5295581 / #3645

@chu11 chu11 self-assigned this Jun 21, 2022
@chu11 chu11 mentioned this issue Jun 21, 2022
Closed
chu11 added a commit to chu11/flux-core that referenced this issue Jun 21, 2022
@chu11
broker: flush content cache on request
a463cb4 
Problem: The content.flush target does not actually flush the
cache.  It only waits for current flushes to complete.  This
goes against documentation and can lead to issues when a cache
flush has not yet initiated.

Solution: Call cache_flush() from within content_flush_request().

Fixes flux-framework#4378
chu11 added a commit to chu11/flux-core that referenced this issue Jun 21, 2022
@chu11
testsuite: Add flux-framework#4378 and flux-framework#4379 regression…
0146d88 
… tests
@chu11 chu11 mentioned this issue Jun 21, 2022
Merged
chu11 added a commit to chu11/flux-core that referenced this issue Jun 21, 2022
@chu11
broker: flush content cache on request
3ddf1cf 
Problem: The content.flush target does not actually flush the
cache.  It only waits for current flushes to complete.  This
goes against documentation and can lead to issues when a cache
flush has not yet initiated.

Solution: Call cache_flush() from within content_flush_request().

Fixes flux-framework#4378
chu11 added a commit to chu11/flux-core that referenced this issue Jun 21, 2022
@chu11
testsuite: Add flux-framework#4378 and flux-framework#4379 regression…
415407d 
… tests
chu11 added a commit to chu11/flux-core that referenced this issue Jun 21, 2022
@chu11
broker: flush content cache on request
fafe898 
Problem: The content.flush target does not actually flush the
cache.  It only waits for current flushes to complete.  This
goes against documentation and can lead to issues when a cache
flush has not been initiated.

Solution: Call cache_flush() from within content_flush_request().

Fixes flux-framework#4378
chu11 added a commit to chu11/flux-core that referenced this issue Jun 21, 2022
@chu11
testsuite: add content cache regression tests
85c5001 
Problem: No tests in the testsuite ensure that content flush
is forced after `flux content flush` nor that any dirty cache
entries are flushed after a content backing module is loaded.
(Issues flux-framework#4378 and flux-framework#4379)

Add regression tests for these specific issues.
chu11 added a commit to chu11/flux-core that referenced this issue Jun 22, 2022
@chu11
testsuite: add content cache regression tests
a9c4419 
Problem: No tests in the testsuite ensure that content flush
is forced after `flux content flush` nor that any dirty cache
entries are flushed after a content backing module is loaded.
(Issues flux-framework#4378 and flux-framework#4379)

Add regression tests for these specific issues.
@mergify mergify bot closed this as completed in b60ab29 Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chu11 chu11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chu11