testsuite: use flux jobs in valgrind workload #4512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: In commit ad5cd8b the "flux job list" command will give a warning / error to the user to use "flux jobs" when the output is a tty. The valgrind workload still uses "flux job list", which can lead to errors when running the valgrind unit tests by hand on the command line. Solution: Use "flux jobs" instead of "flux job list" in the valgrind workload.
Codecov Report
@@ Coverage Diff @@
## master #4512 +/- ##
=======================================
Coverage 83.36% 83.37%
=======================================
Files 401 401
Lines 67649 67649
=======================================
+ Hits 56398 56399 +1
+ Misses 11251 11250 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: In commit
ad5cd8b
the "flux job list" command will give a warning / error to the user
to use "flux jobs" when the output is a tty. The valgrind workload
still uses "flux job list", which can lead to errors when running the
valgrind unit tests by hand on the command line.
Solution: Use "flux jobs" instead of "flux job list" in the valgrind
workload.