job-list: misc cleanup #4563
Merged
job-list: misc cleanup #4563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A number of comments still refer to the module as job-info instead of job-list. Solution: Update comments appropriately.
Problem: The journal_submit_event() function takes a timestamp parameter that is never used. Remove unused parameter.
jameshcorbett
force-pushed
the
job_list_cleanup
branch
from
e6f99f6
to
a9a7003
Compare
Codecov Report
@@ Coverage Diff @@
## master #4563 +/- ##
==========================================
+ Coverage 83.36% 83.38% +0.01%
==========================================
Files 403 403
Lines 68047 68041 -6
==========================================
+ Hits 56730 56737 +7
+ Misses 11317 11304 -13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few misc cleanups that were peeled off of a now-tabled PR