broker: support binomial tree topology #4730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grondo
approved these changes
Oct 27, 2022
garlick
force-pushed
the
binomial_tree
branch
from
6b9e84e
to
7b4c8d2
Compare
|
Thanks, I went ahead and added an update to BTW, it was your suggestion of using a URI for the topology that made this so simple. That was a good one! |
Codecov Report
@@ Coverage Diff @@
## master #4730 +/- ##
==========================================
+ Coverage 80.05% 83.35% +3.30%
==========================================
Files 413 413
Lines 69309 69756 +447
==========================================
+ Hits 55483 58147 +2664
+ Misses 13826 11609 -2217
|
Problem: the binomial tree has some interesting properties for HPC overlay networks, but we only support k-ary and custom topologies. This topology has been explored extensively for use in MPI collectives, such as in "Optimization of Collective Communication Operations in MPICH", Rajeev Thakur et al, IJHPCA, 2005. A binomial tree of order k has the following general properties: - it has 2^k nodes - the root has fanout k - each level has a maximum fanout of one less than the next level up - its height is k See also page 4 of: https://www3.cs.stonybrook.edu/~rezaul/Fall-2017/CSE548/CSE548-lecture-9.pdf How these properties might affect Flux TBON performance is an open question, but now we have an option to experiment with.
Problem: no unit tests exist for binomial topology. Add unit tests.
Problem: no system tests exist for tbon.topo=binomial Add one to t0001-basic.t.
Problem: tbon.topo=binomial is not documented. Add binomial to the tbon.topo attribute description.
garlick
force-pushed
the
binomial_tree
branch
from
7b4c8d2
to
d80be12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think @trws suggested we try a binomial tree overlay topology. This adds an option to play with: