Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: missing checks in configure #5444

Closed
grondo opened this issue Sep 11, 2023 · 2 comments · Fixed by #5839
Closed

build: missing checks in configure #5444

grondo opened this issue Sep 11, 2023 · 2 comments · Fixed by #5839

Comments

@grondo
Copy link
Contributor

grondo commented Sep 11, 2023

In #5443 a couple missing checks in configure were discovered:

  • The python ply package
  • libsodium

I'm not sure about libsodium. It seems to only be required by flux-keygen, which only uses it to print the sodium version. Still required?
@garlick
Copy link
Member

garlick commented Sep 11, 2023

It adds the libsodium version to the certificate metadata but we don't do anything with that.

We used to use it for base64, but we switched to ccan for that.

I agree, we can drop it.

@grondo
Copy link
Contributor Author

grondo commented Sep 11, 2023

I'll open a separate issue for that, then. Thanks!

@grondo grondo mentioned this issue Sep 11, 2023
Closed
grondo added a commit to grondo/flux-core that referenced this issue Mar 27, 2024
@grondo
configure: require python3-ply >= 3.9
9f21879 
Problem: flux-core requires the Python ply module, but configure
doesn't check for it.

Add a check for this required module in configure.

Fixes flux-framework#5444
@grondo grondo mentioned this issue Mar 27, 2024
Merged
grondo added a commit to grondo/flux-core that referenced this issue Mar 27, 2024
@grondo
configure: require python3-ply >= 3.9
82a344f 
Problem: flux-core requires the Python ply module, but configure
doesn't check for it.

Add a check for this required module in configure.

Fixes flux-framework#5444
@mergify mergify bot closed this as completed in #5839 Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure: add missing check for python ply >= 3.9 grondo/flux-core
2 participants
@garlick @grondo