Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: remove excessive logging #5804

Merged
merged 2 commits into from Mar 18, 2024
Merged

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Mar 18, 2024

Problem: When a namespace is marked for removal, it is normal to cleanup lingering/left over transactions that are not yet complete. On some tests, this appears to lead to many unnecessary log messages.

Remove log messages related to cleanup of transactions on removed namespaces. They are unnecessary and excessive. Those transactions will receive a ENOTSUP error and can report that the namespace has been removed.

Fixes #5789

Problem: A comment in error_event_cb() was not the most clear.

Add a little extra info.
Problem: When a namespace is marked for removal, it is normal to
cleanup lingering/left over transactions that are not yet complete.
On some tests, this appears to lead to many unnecessary log messages.

Remove log messages related to cleanup of transactions on removed
namespaces.  They are unnecessary and excessive.  Those transactions
will receive a ENOTSUP error and can report that the namespace has
been removed.

Fixes flux-framework#5789
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@mergify mergify bot merged commit b049561 into flux-framework:master Mar 18, 2024
33 checks passed
@chu11 chu11 deleted the issue5789 branch March 20, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kvs[0]: error_event_cb: received unknown namespace
2 participants