Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvs: remove excessive logging #5804

Merged
merged 2 commits into from
Mar 18, 2024
Merged

kvs: remove excessive logging #5804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9853ade
kvs: add error handling info in comments
chu11 Mar 18, 2024
6871f7e
kvs: remove excessive logging
chu11 Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 8 additions & 12 deletions src/modules/kvs/kvs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,8 +950,6 @@ static void kvstxn_apply (kvstxn_t *kt)
assert (root);

if (root->remove) {
flux_log (ctx->h, LOG_DEBUG, "%s: namespace %s removed", __FUNCTION__,
ns);
errnum = ENOTSUP;
goto done;
}
Expand Down Expand Up @@ -2066,14 +2064,15 @@ static void error_event_cb (flux_t *h, flux_msg_handler_t *mh,
}

/* if root not initialized, nothing to do
* - it is ok that the namespace be marked for removal, we may be
* cleaning up lingering transactions.
* - note that it is possible the namespace has been marked for
* removal, we may be cleaning up lingering transactions and
* need to report to those callers that namespace not available
* via finalize_transaction_bynames() below.
* - i.e. we're calling kvsroot_mgr_lookup_root() not
* kvsroot_mgr_lookup_root_safe().
*/
if (!(root = kvsroot_mgr_lookup_root (ctx->krm, ns))) {
flux_log (ctx->h, LOG_ERR, "%s: received unknown namespace %s",
__FUNCTION__, ns);
if (!(root = kvsroot_mgr_lookup_root (ctx->krm, ns)))
return;
}

finalize_transaction_bynames (ctx, root, names, errnum);
}
Expand Down Expand Up @@ -2125,11 +2124,8 @@ static void setroot_event_cb (flux_t *h, flux_msg_handler_t *mh,
* order (commit/fence completes before namespace removed, but
* namespace remove event received before setroot).
*/
if (!(root = kvsroot_mgr_lookup_root (ctx->krm, ns))) {
flux_log (ctx->h, LOG_ERR, "%s: received unknown namespace %s",
__FUNCTION__, ns);
if (!(root = kvsroot_mgr_lookup_root (ctx->krm, ns)))
return;
}

if (root->setroot_pause) {
flux_msg_t *msgcpy;
Expand Down