python: fix handle barrier method to return a Future #5825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The flux_barrier(3) function returns a future, but the Python wrapper function calls the C api without returning anything. Return the result of flux_barrier() wrapped in a Future so that the call is functional from Python.
Problem: The issues/t2492-shell-lost.sh reproducer calls flux_barrier() but does not wait for the result. Add the missing .get() call to h.barrier().
Problem: The get() calls to the Python barrier() methods are missing in t/python/t0003-barrier.py. Add the missing get() calls.
|
FYI - as a side effect this should fix the intermittent CI failures of |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5825 +/- ##
==========================================
- Coverage 83.36% 83.35% -0.02%
==========================================
Files 509 509
Lines 82515 82515
==========================================
- Hits 68787 68777 -10
- Misses 13728 13738 +10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flux_barrier(3)returns aflux_future_t, but the Python handle barrier method returns nothing.This PR returns a Future from
handle.barrier()as is necessary for proper functionality and updates callers.Note: Clearly the barrier unit tests were not working, but I didn't have any good ideas how to properly test the barrier functionality, so left it alone for now besides addition of the missing
get()calls.