Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: fix handle barrier method to return a Future #5825

Merged
merged 3 commits into from
Mar 25, 2024
Merged

python: fix handle barrier method to return a Future #5825

merged 3 commits into from
Mar 25, 2024

Commits on Mar 24, 2024

  1. python: return a Future from handle barrier method 

    Problem: The flux_barrier(3) function returns a future, but the Python
wrapper function calls the C api without returning anything.

Return the result of flux_barrier() wrapped in a Future so that the
call is functional from Python.
    @grondo
    grondo committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    87cd4a3 View commit details
    Browse the repository at this point in the history

  2. testsuite: fix barrier call in issues/t2492-shell-lost.sh 

    Problem: The issues/t2492-shell-lost.sh reproducer calls flux_barrier()
but does not wait for the result.

Add the missing .get() call to h.barrier().
    @grondo
    grondo committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    42ceab1 View commit details
    Browse the repository at this point in the history

  3. testsuite: fix barrier call in python/t0003-barrier.py 

    Problem: The get() calls to the Python barrier() methods are missing
in t/python/t0003-barrier.py.

Add the missing get() calls.
    @grondo
    grondo committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    25ac989 View commit details
    Browse the repository at this point in the history