New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor cleanup in job-manager journal and job-list (mostly inline docs) #5850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, per offline discussion, my stuff will go into a different PR.
I added some more - maybe have one more look before I set MWP? |
LGTM still |
e1a8444
to
192f02e
Compare
restarting fedora 38 builder that failed here:
|
Problem: a comment in job-list claims the flux-restart event will not be seen, but recent changes have made it possible when processing the journal backlog, if the system was shut down with jobs in SCHED state. Update comment.
Problem: job-manager defines DEFAULT_JOURNAL_SIZE_LIMIT but this is no longer used. Drop definition.
Problem: some commented out code uses EVENT_JOURNAL_ONLY but this flag was renamed to EVENT_NO_COMMIT. Rename flag.
Problem: a comment refers to event sequence numbers but we don't have those anymore. Update comment.
Problem: the journal protocol is undocumented. Add a comment block at the top of journal.c that'll do for now.
192f02e
to
b47b3c9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5850 +/- ##
==========================================
+ Coverage 83.26% 83.30% +0.03%
==========================================
Files 513 513
Lines 82727 82727
==========================================
+ Hits 68882 68915 +33
+ Misses 13845 13812 -33
|
@chu11 and I were both looking through the job-list source to be sure all is OK before we tag, and we both spotted some incorrect source comments. Al, feel free to add to this PR.