Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor cleanup in job-manager journal and job-list (mostly inline docs) #5850

Merged
merged 5 commits into from
Apr 5, 2024
Merged

minor cleanup in job-manager journal and job-list (mostly inline docs) #5850

merged 5 commits into from
Apr 5, 2024

Commits on Apr 5, 2024

  1. job-list: update flux-restart event comment 

    Problem: a comment in job-list claims the flux-restart event will
not be seen, but recent changes have made it possible when processing
the journal backlog, if the system was shut down with jobs in SCHED
state.

Update comment.
    @garlick
    garlick committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    27134b6 View commit details
    Browse the repository at this point in the history

  2. job-manager: drop unused #define 

    Problem: job-manager defines DEFAULT_JOURNAL_SIZE_LIMIT but
this is no longer used.

Drop definition.
    @garlick
    garlick committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    41ed477 View commit details
    Browse the repository at this point in the history

  3. job-manager: update commented out flag 

    Problem: some commented out code uses EVENT_JOURNAL_ONLY
but this flag was renamed to EVENT_NO_COMMIT.

Rename flag.
    @garlick
    garlick committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    415b866 View commit details
    Browse the repository at this point in the history

  4. job-manager: drop event sequence# from comment 

    Problem: a comment refers to event sequence numbers but
we don't have those anymore.

Update comment.
    @garlick
    garlick committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c137be3 View commit details
    Browse the repository at this point in the history

  5. job-manager: add comment describing journal proto 

    Problem: the journal protocol is undocumented.

Add a comment block at the top of journal.c that'll do for now.
    @garlick
    garlick committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    b47b3c9 View commit details
    Browse the repository at this point in the history