Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux-perilog-run: timeout not working with --exec-per-rank #6073

Closed
grondo opened this issue Jul 2, 2024 · 2 comments
Closed

flux-perilog-run: timeout not working with --exec-per-rank #6073

grondo opened this issue Jul 2, 2024 · 2 comments
Labels

Comments

@grondo
Copy link
Contributor

grondo commented Jul 2, 2024

The default timeout doesn't seem to be firing on actual systems for flux perilog-run prolog. There's testing in the testsuite with local scripts, but not with --exec-per-rank, so perhaps timeouts aren't working in that implementation.

@grondo
Copy link
Contributor Author

grondo commented Jul 10, 2024

The issue is that the default here

async def run_with_timeout(cmd, label, timeout=1800.0):

is overridden because run_with_timeout() is called with timeout=args.timeout and the default for args.timeout is None. So there is no default timeout.

@grondo grondo added the wontfix label Aug 30, 2024
@grondo
Copy link
Contributor Author

grondo commented Aug 30, 2024

Closed as wontfix

@grondo grondo closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant