Convert to inttypes.h conversion specifiers #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76.05% (diff: 88.46%)@@ master #940 diff @@
==========================================
Files 149 149
Lines 25951 25951
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 19747 19738 -9
- Misses 6204 6213 +9
Partials 0 0
|
|
Cool! I didn't know about %z. One nit, the |
|
OK, I'll fix that up. |
Change the printf conversion specifiers to use the portable macros from inittypes.h. For instance, instead of guessing %lu for a uint32_t, use the PRIu32 macro. Also change the length modifier for size_t types to "z", which is an explicit printf length modifier for size_t and ssize_t arguments. Remove uses of The %m conversion specifier. While it is convenient, it is explicitly listed as a Glibc extension and therefore less portable. In subprocess.c, the %m was already redundant with the error string appened by log_err(), so they were simply removed. The one final instance of %m in popen2.c was converted to an explicit %s and strerr(errno). Closes #394
|
That's got it, thank you. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the printf conversion specifiers to use the portable
macros from inittypes.h. For instance, instead of guessing %lu for
a uint32_t, use the PRIu32 macro.
Also change the length modifier for size_t types to "z", which is
an explicit printf length modifier for size_t and ssize_t arguments.
Finally, any %m conversion specifiers are replaced with explicit
%s and strerror(errno). The %m is convenient, but it is explicitly
listed as a Glibc extension and therefore less portable.
Closes #394