Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop man page stub that cannot be generated #1258

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Oct 25, 2017

Apparently we've asked asciidoc to generate one too many
man page stubs from flux_kvs_txn_create.adoc.

Since it's not generated, make install fails. For now,
drop the stub from the Makefile.am so make install can work.

Fixes #1256

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 25, 2017

Ok, that will work for now I guess. I guess we should open a longer term issue to deal with the missing manpage?

@garlick garlick force-pushed the garlick:issue1256 branch from 5a36d08 to 2f5a3a8 Oct 25, 2017

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 25, 2017

Codecov Report

Merging #1258 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1258      +/-   ##
==========================================
- Coverage   77.89%   77.88%   -0.02%     
==========================================
  Files         154      154              
  Lines       28934    28934              
==========================================
- Hits        22537    22534       -3     
- Misses       6397     6400       +3
Impacted Files Coverage Δ
src/broker/modservice.c 80.58% <0%> (-0.98%) ⬇️
src/common/libflux/response.c 83.73% <0%> (-0.82%) ⬇️
src/common/libkvs/kvs_txn.c 74.01% <0%> (-0.57%) ⬇️
src/broker/module.c 83.79% <0%> (-0.28%) ⬇️
src/common/libflux/handle.c 83.66% <0%> (-0.25%) ⬇️
src/common/libkvs/kvs.c 64.03% <0%> (ø) ⬆️
src/modules/kvs/kvs.c 62.62% <0%> (ø) ⬆️
src/common/libflux/message.c 81.6% <0%> (+0.11%) ⬆️
src/common/libutil/base64.c 95.77% <0%> (+0.7%) ⬆️
build: drop man page stub that cannot be generated
Apparently we've asked asciidoc to generate one too many
man page stubs from flux_kvS_txn_create.adoc.

Since it's not generated, make install fails.  For now,
drop the stub from the Makefile.am so make install can work.

Fixes #1256
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 25, 2017

Coverage Status

Coverage increased (+0.007%) to 78.499% when pulling 5a36d08 on garlick:issue1256 into 2694116 on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Oct 25, 2017

Restarted one builder that failed here:

FAIL: t0001-basic.t 53 - instance can stop cleanly with subscribers (#1025)

that might be a new one but shouldn't be related to this PR.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 25, 2017

Here's full output:

expecting success: 
	flux start ${ARGS} -s2 --bootstrap=selfpmi bash -c "nohup flux event sub hb &"

lt-flux-broker: module 'aggregator' was not cleanly shutdown
lt-flux-broker: module 'barrier' was not cleanly shutdown
lt-flux-broker: module 'kvs' was not cleanly shutdown
lt-flux-broker: module 'job' was not cleanly shutdown
lt-flux-broker: module 'resource-hwloc' was not cleanly shutdown
flux-event: flux_event_subscribe: Success
flux-start: 0 (pid 7531) Killed
not ok 53 - instance can stop cleanly with subscribers (#1025)

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Oct 25, 2017

Thanks. I restarted another one that hung during setup.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 25, 2017

Coverage Status

Coverage decreased (-0.01%) to 78.499% when pulling 2f5a3a8 on garlick:issue1256 into 1220202 on flux-framework:master.

@grondo grondo merged commit b12d027 into flux-framework:master Oct 25, 2017

3 of 4 checks passed

codecov/project 77.88% (-0.02%) compared to 1220202
Details
codecov/patch Coverage not affected when comparing 1220202...2f5a3a8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 78.499%
Details
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 25, 2017

Thanks!

@garlick garlick deleted the garlick:issue1256 branch Nov 8, 2017

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.