Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/kvs: Support namespace timeout #1316

Merged
merged 1 commit into from Jan 17, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Jan 11, 2018

If a namespace has not been touched/modified on a follower node
for a long period of time, and no one is watching a key on it,
and no unfinished fences are lingering, remove the namespace from the node.

The namespace still lives on in the rank 0 leader node, but data/info
is not replicated on follower nodes.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 11, 2018

Codecov Report

Merging #1316 into master will decrease coverage by 0.01%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #1316      +/-   ##
==========================================
- Coverage   78.21%   78.19%   -0.02%     
==========================================
  Files         155      155              
  Lines       28189    28198       +9     
==========================================
+ Hits        22047    22049       +2     
- Misses       6142     6149       +7
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 65.22% <60%> (-0.26%) ⬇️
src/cmd/flux-event.c 67.74% <0%> (-1.08%) ⬇️
src/common/libflux/response.c 83.73% <0%> (-0.82%) ⬇️
src/common/libutil/base64.c 95.07% <0%> (-0.71%) ⬇️
src/common/libflux/future.c 88.78% <0%> (-0.47%) ⬇️
src/broker/overlay.c 73.88% <0%> (-0.32%) ⬇️
src/common/libflux/message.c 81.48% <0%> (ø) ⬆️
src/bindings/lua/flux-lua.c 81.16% <0%> (+0.08%) ⬆️
src/modules/connector-local/local.c 72.95% <0%> (+0.2%) ⬆️
... and 2 more
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 11, 2018

Coverage Status

Coverage decreased (-0.005%) to 78.581% when pulling 6e0f279 on chu11:kvsremovenamespacetimeout into a4d438a on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Jan 11, 2018

oops, i made an obvious mistake. ignore for now

@chu11 chu11 force-pushed the chu11:kvsremovenamespacetimeout branch from 6e0f279 to 437afce Jan 11, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Jan 11, 2018

Fixed the issue. Testing was done by hand by hand lowering the timeout & watching for a hand added log message.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2018

Coverage Status

Coverage decreased (-0.06%) to 78.531% when pulling 437afce on chu11:kvsremovenamespacetimeout into a4d438a on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Jan 16, 2018

Looks good, just needs a rebase.

modules/kvs: Support namespace timeout
If a namespace has not been touched/modified on a follower node
for a long period of time, and no one is watching a key on it,
and no unfinished fences are lingering, remove the namespace from the node.

The namespace still lives on in the rank 0 leader node, but data/info
is not replicated on follower nodes.

@chu11 chu11 force-pushed the chu11:kvsremovenamespacetimeout branch from 437afce to 4499712 Jan 16, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Jan 16, 2018

re-based

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 17, 2018

Coverage Status

Coverage decreased (-0.02%) to 78.523% when pulling 4499712 on chu11:kvsremovenamespacetimeout into 879ff60 on flux-framework:master.

@garlick garlick merged commit 877a6fd into flux-framework:master Jan 17, 2018

3 of 5 checks passed

codecov/patch 60% of diff hit (target 78.21%)
Details
codecov/project 78.19% (-0.02%) compared to 879ff60
Details
buildbot/core_standard Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 78.523%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.