modules/kvs: Support namespace timeout #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1316 +/- ##
==========================================
- Coverage 78.21% 78.19% -0.02%
==========================================
Files 155 155
Lines 28189 28198 +9
==========================================
+ Hits 22047 22049 +2
- Misses 6142 6149 +7
|
|
oops, i made an obvious mistake. ignore for now |
chu11
force-pushed
the
kvsremovenamespacetimeout
branch
from
6e0f279
to
437afce
Compare
|
Fixed the issue. Testing was done by hand by hand lowering the timeout & watching for a hand added log message. |
|
Looks good, just needs a rebase. |
If a namespace has not been touched/modified on a follower node for a long period of time, and no one is watching a key on it, and no unfinished fences are lingering, remove the namespace from the node. The namespace still lives on in the rank 0 leader node, but data/info is not replicated on follower nodes.
chu11
force-pushed
the
kvsremovenamespacetimeout
branch
from
437afce
to
4499712
Compare
|
re-based |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a namespace has not been touched/modified on a follower node
for a long period of time, and no one is watching a key on it,
and no unfinished fences are lingering, remove the namespace from the node.
The namespace still lives on in the rank 0 leader node, but data/info
is not replicated on follower nodes.