Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpmi: drop pmix client support and --with-pmix configure option #1663

Merged
merged 4 commits into from Sep 15, 2018

Conversation

garlick
Copy link
Member

@garlick garlick commented Sep 14, 2018

pmix code added to flux for sierra was not especially helpful, and caused a few problems. As discussed in #1662, this PR backs it out.

We'll need some RPM on that architecture to provide libpmix (with libpmi.so) that interoperates with spectrum MPI's built-in version, by the time we roll out the next release of Flux on sierra.

@grondo
Copy link
Contributor

grondo commented Sep 14, 2018

This seems wise, as I think the --with-pmix option also caused some confusion for users.

Thanks! I'm fine with merging, but we should probably get at least one more ack first.

@SteVwonder
Copy link
Member

Per @trws's suggestion in #1662:

Should we add a recommended dep or similar on an external PMIX with PMI?

Can this PR also update the readme to specify that we require either a PMI libary or a PMIx library with PMI compatibility?

@garlick
Copy link
Member Author

garlick commented Sep 14, 2018

Good idea, I'll tack on an update to README.md.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 79.931% when pulling 773c10b on garlick:nix_pmix into 7c38aa3 on flux-framework:master.

@grondo grondo merged commit 506d305 into flux-framework:master Sep 15, 2018
@grondo
Copy link
Contributor

grondo commented Sep 15, 2018

Thanks @garlick!

@garlick garlick deleted the nix_pmix branch September 21, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants