Tweaks to docker build script #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `--no-home` option to the `docker-run-checks.sh` script. Useful for building on Mac OSX where mounting the home directory within a Linux container can cause issues down the road. For example, the $HOME in OSX is `/Users/$username`, but in linux, it is `/home/$username`. Some tools, like ssh-ident and emacs, can create files in your home directory with absolute path information in them. Launching these tools within the linux docker container while the host Mac OSX home directory is mounted can lead to inconsistent state. Additionally, if you are a hyper-conservative user, this limits the exposure and risk of running the script.
The bionic-base image only has `/bin/bash` and `/bin/dash` shells. If
`${SHELL}` is set to anything else (e.g. `/bin/zsh`), the interactive container
fails to run. Hardcodes the shell command to `/bin/bash` to ensure the
interactive session always works.
Codecov Report
@@ Coverage Diff @@
## master #1688 +/- ##
=========================================
+ Coverage 79.29% 79.3% +<.01%
=========================================
Files 186 186
Lines 35059 35059
=========================================
+ Hits 27801 27803 +2
+ Misses 7258 7256 -2
|
|
Going to go ahead and merge if that's ok. It will be interesting to see if we hit the same travis-ci errors on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are for better compatibility with Mac OSX, but one of the changes is also for users that don't use
/bin/bashas their${SHELL}.Changes:
--no-home/bin/bashregardless of${SHELL}