Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
broker: misc cleanup / refactoring #2178
While looking at #1036, fixed up a bunch of tiny issues I saw. Also refactored a few things for consistency. Note that some of these might eventually lead to more cleanup / refactoring (i.e. some type of
When trying to restore default sigmasks, do not log_err_exit() on error, just fallthrough to continue cleanup path of broker.
For consistency, make all create functions (i.e. attr_create(), heartbeat_create(), etc.) return ENOMEM on error. Check for error appropriately from callers.
Rename to shutdown_set_flux() for consistency to rest of broker (i.e. content_cache_set_flux(), hello_set_flux(), etc.).
Hmmm, hit a valgrind issue in 1 run, but nothing obvious. Re-run