Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libflux: make flux_msg_fprint() output clearer #3742

Merged
merged 2 commits into from
Jun 29, 2021
Merged

libflux: make flux_msg_fprint() output clearer #3742

merged 2 commits into from
Jun 29, 2021

Commits on Jun 29, 2021

  1. libflux/test: add verbose option to message tests 

    Problem: It can be difficult to test/debug flux_msg_fprint tests
becauses tests default to routing all output to /dev/null.

Solution: Support a simple verbose option in test/message.c to have
fprintf output go to stderr.
    @chu11
    chu11 committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    4e8bf96 View commit details
    Browse the repository at this point in the history

  2. libflux: make flux_msg_fprint() output clearer 

    Problem: With zmsg_t being removed from the internals of the
flux_msg_t data structure (commit
cd0cbfb), flux_msg_fprint() is no
longer beholden to the output format from zframe_fprint().  A more
clear format for debugging can be output.

Solution: Update flux_msg_fprint() to output all fields in a more
clear format, with many fields output with key=value output and output
string representations of integer values when valuable.  In addition,
output portion of the payload up to a line limit.

Add additional unit tests for coverage.
    @chu11
    chu11 committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    a0d3dbb View commit details
    Browse the repository at this point in the history