resource: stop collecting/reducing hwloc XML #4263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh darn, looks like fluxion is failing a few tests: |
|
I reran the sched test after sched merged the PR to disable the failing tests, but it looks like there may be another set that I missed before? |
garlick
force-pushed
the
no_xml_collect
branch
2 times, most recently
from
f5cda56
to
974ba5c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4263 +/- ##
========================================
Coverage 83.54% 83.55%
========================================
Files 387 387
Lines 64867 64725 -142
========================================
- Hits 54194 54081 -113
+ Misses 10673 10644 -29
|
|
Rebased on current master and added a commit that improves error responses for unknown service methods (noticed while tracking down fluxion's use of the deprecated This won't pass the sched CI test until flux-framework/flux-sched#929 is merged. |
|
The sched PR was merged so kicking of CI again. |
|
Thanks! |
Problem: the resource module collects hwloc XML to rank 0 by tacking it onto its Rlocal -> R reduction. This was to support fluxion while an Rv1 reader was being developed. That has now been completed, so this can be removed. Don't aggregate hwloc XML at rank 0. Drop the resource.get-xml RPC used by fluxion. Update resource tests.
Problem: the message dispatcher returns a human readable error when requests that don't match a handler, but the topic is not included, which is inconvenient when diagnosing failures. Add the topic to the error response. Also, clean up message topic usage in this function: - set topic to "unknown" if flux_msg_get_topic() fails to avoid uninitialized variable contents being passed to caliper on failure - eliminate duplicate flux_msg_get_topic() in fprintf call that is used as a last resort when a message is going to be dropped
garlick
added a commit
to garlick/flux-core
that referenced
this pull request
Mar 1, 2024
Problem: a comment in topo.c states that XML is reduced along with R_local, however this is not true. XML is no longer reduced since flux-framework#4263 (in flux-core-0.39.0). Drop that part of the comment.
grondo
pushed a commit
to garlick/flux-core
that referenced
this pull request
Mar 4, 2024
Problem: a comment in topo.c states that XML is reduced along with R_local, however this is not true. XML is no longer reduced since flux-framework#4263 (in flux-core-0.39.0). Drop that part of the comment.
garlick
added a commit
to garlick/flux-core
that referenced
this pull request
Mar 5, 2024
Problem: a comment in topo.c states that XML is reduced along with R_local, however this is not true. XML is no longer reduced since flux-framework#4263 (in flux-core-0.39.0). Drop that part of the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that fluxion has the Rv1 reader (flux-framework/flux-sched#921), it no longer requires the
resource.get-xmlRPC to fetch aggregated hwloc XML for the instance. This PR removes that RPC and leaves the hwloc XML out of the Rlocal ➡️ reduction, greatly reducing the amount of data that needs to be moved before the scheduler can be started when resources are dynamically discovered (e.g. under slurm).This PR is based on top of #4262 (remove
flux-hwloc)