flux-jobs: support emoji output formats #4687
Conversation
|
Take my money now!! 😍 |
|
Hotline, get ready. User: Flux gave my job a poop emoji and I don't know why Hotline: Hmm, your job was canceled so it should be a plucky little bomb. What sort of poop is it? User: it has a maniacal grin Hotline: I'm not familiar with that job result. Are you sure it wasn't exploding in some way? User: not really Hotline: (consults Flux documentation) Could it have been "Shocked Face with Exploding Head"? How about "Potato"? |
|
I am glad you are not using the thumbs-up emoji. On todays news: |
|
Sadly, it is difficult to capture jobs stuck in the CLEAN state: https://unicode-table.com/en/1F9FB/ User: my job was stuck in the toilet paper state, then later flux said it was poop |
Hotline: Please flux it down... |
🧼 or ✨ or perhaps even ❇️ might work for clean. I suppose 🧹 could too. |
|
I like the ✨ … Mr Clean approved! |
|
Oops, I really mean the "CLEANUP" state, so I think 🧼 or 🧹 seem like pretty good options. I considered 🗑 as well, but felt that was where trash goes, not the act of cleaning up. These are critically important decisions we're making here. Gonna make sure we get this right! |
|
🫧 or 🧽? |
|
I forgot about the bubbles, for cleanup based on the iOS iconography I like the soap, bubbles or broom best I think. They all look like something in active use for that purpose.
…---
Sent from Workspace ONE Boxer<https://whatisworkspaceone.com/boxer>
On October 13, 2022 at 8:51:30 PM PDT, Vanessasaurus ***@***.***> wrote:
🫧 or 🧽?
—
Reply to this email directly, view it on GitHub<https://urldefense.us/v3/__https://github.com/flux-framework/flux-core/pull/4687*issuecomment-1278444447__;Iw!!G2kpM7uM-TzIFchu!lq-iKCllaFzrGGSUd_gpG7grr1gTKdWbGUrQG3tqeuW7EuvuEJFCdB_J93crWJf-Xw$>, or unsubscribe<https://urldefense.us/v3/__https://github.com/notifications/unsubscribe-auth/AAFBFNPEI3ZA66JRA6D5CVLWDDKD3ANCNFSM6AAAAAAREVEJQE__;!!G2kpM7uM-TzIFchu!lq-iKCllaFzrGGSUd_gpG7grr1gTKdWbGUrQG3tqeuW7EuvuEJFCdB_J93f71AcZlw$>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
ok, we'll go with broom ... mainly b/c the sponge looks like a peanut in some other font sets. any opinions on depend - ✋ i think sched is pretty good (i tried clock but didn't like it as much), but depend and priority are meh ... |
|
What about 🚦for priority? |
|
Could do ⏹️ or 🛑 for depend I guess, ⏸️ could also work unless we have a paused state?
I could see ⏸️ > 📅 >
|
|
Oh I really like the orange - it stands out nicely. |
Oh I like that for priority, i.e. like "waiting for green" / "waiting to go" .... although I guess that could be for depend too. |
|
@trws ohh pause is a good idea, i like that one for depend. |
|
doh! the pause button displayed poorly in gnome (just two vertical bars). And for some reason, gnome is missing a chunk of emojis at the higher numbers, dunno if it was a more recent unicode addition and gnome just doesn't have in my version (which would be used by a fair amount of staff at the lab). So broom and soap didn't display. So I went with new -> wrapped gift (note, should be virtually impossible to ever see)
I've been using this dinky script to test if anyone wants to try on their terminal. (you may need to adjust the number of tasks to get both running & pending jobs on your machine) |
Also, I'll just mention that |
Oh yeah, i totally forgot! |
|
For the life of me I cannot get the wastebasket to align, i think its width is different than the rest:
|
|
Yeah... It might well be, or its string width might be while its display
width is the same. We would probably need ICU or similar to work it out
right, which we actually have already through one of our other vendored
dependencies but it's not a trivial amount of work.
Al Chu ***@***.***> writes:
… For the life of me I cannot get the wastebasket to align, i think its width
is different than the rest:
image
#!/bin/sh
flux jobs -a --format="{id:>12} {status:<10} {state_emoji:<6} {result_emoji:<6} {status_emoji:<6} {nodelist}" --from-stdin < emojitest.txt
emojitest.txt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
chu11
force-pushed
the
issue4681_result_emoji
branch
from
86fe536
to
a78c632
Compare
|
Idea: add |
I like it! I could be the default output but with |
chu11
force-pushed
the
issue4681_result_emoji
branch
from
a78c632
to
5992749
Compare
|
re-pushed, adding
|
|
Should the heading be just |
I did "STATUS" b/c the abbreviated headings were a little narrow for potentially wide emojis. hmmm, an emoji as a header may solve alignment. Nothing comes to mind on the emoji list, could just do a ❓ |
|
I don't think this would hurt to merge as is since it's not a default output format and discussion has tailed off - if you're ready that is. Looks like there's at least a conflict to fix up |
Yup, I'm good with it, lemme fix up that conflict. |
chu11
force-pushed
the
issue4681_result_emoji
branch
from
5992749
to
e63b28c
Compare
Problem: flux lacks a certain cuteness factor. This limits its
potential to be liked by younger HPC users.
Solution: Support the {state_emoji}, {result_emoji}, and
{status_emoji} fields, which will output the emojis representing job states
or results respectively.
Fixes flux-framework#4681
Problem: emoji output fields are not documented in flux-jobs(1).
Solution: Add {state_emoji}, {result_emoji}, and {status_emoji}
output fields.
Problem: emoji output tests were missing Add some coverage in t2800-jobs-cmds.t.
Problem: In order to get emoji outputs in flux-jobs, users have to
use output fields in a format string. Users need access to emojis
yesterday, they don't have time to learn how to format emojis.
Add a "cute" output format. It's the same as the default output but
uses "{status_emoji}" instead of "{status_abbrev}".
chu11
force-pushed
the
issue4681_result_emoji
branch
from
f47fc0e
to
c3c8d9c
Compare
|
re-pushed fixing up conflict and a python isort issue that is now discovered |
Codecov Report
@@ Coverage Diff @@
## master #4687 +/- ##
==========================================
- Coverage 84.24% 83.35% -0.90%
==========================================
Files 410 413 +3
Lines 61515 69664 +8149
==========================================
+ Hits 51826 58069 +6243
- Misses 9689 11595 +1906
|
Problem: flux lacks a certain cuteness factor. This limits its potential to be liked by younger HPC users.
Solution: Support the {state_emoji}, {result_emoji}, and {status_emoji} fields, which will output the emojis representing job states
or results respectively.
Fixes #4681
Note, while this was originally brought up as a joke in a discussion, this isn't actually that un-useful. When listing a bunch of jobs, it may be easier to visually scan for a poop instead of printed text like FAIL. So I selected emojis based on some visual "scan-ability".
Emoji alignment is difficult, but largely ignored it as it's going to be font and terminal specific.
Let the bike-shedding of emoji choices begin!