You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the github workflow that does our auto-release on tags. There was an incorrect key used in the yaml, and also step that wasn't necessary anymore. Also, "upgrades" the softprops/action-gh-release action which was inadvertently downgraded by a recent commit.
Fixes#4751 (though we really won't know until the next tag)
Problem: The GitHub auto-release action has an incorrect key in the
workflow yaml, and also includes a step that doesn't do anything.
Rename the 'release_name' key to just 'name', and remove the prep
release step which is no longer necessary.
Problem: In commit 286df0a the
softprops/actions-gh-release was pinned to a "newer" release by git
hash, but this project seems to move the v1 tag to the latest release
in the v1.x series, so the version was actually downgraded. This came
with some bugs that have been fixed.
Revert the softprops/action-gh-release version to @v1.
@vsoch: you might want to check the "latest version" for softprops/action-gh-release in your github action updater, it seems like they currently move the v1 tag to point to the latest release? (See https://github.com/softprops/action-gh-release/tags), so the latest auto-update actually downgraded our version of that action.
@grondo the reason for this is that we only "trust" major versions (akin to v1) for the list of trusted repos (e.g,. github maintained like actions/checkout) and for untrusted, we require a semantic version. So the tool was honoring that preference here, and if we ran again we would just add this particular repository to be under trusted.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the github workflow that does our auto-release on tags. There was an incorrect key used in the yaml, and also step that wasn't necessary anymore. Also, "upgrades" the softprops/action-gh-release action which was inadvertently downgraded by a recent commit.
Fixes #4751 (though we really won't know until the next tag)