broker: make tbon.connect_timeout configurable #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll set MWP. |
Problem: connect timeout will require nearly replicating the overlay_configure_tcp_user_timeout() function. Restructure the function so it can be used for configuring tcp_user_timeout and, in the future, connect_timeout.
Problem: there is no way to tune the ZMQ_CONNECT_TIMEOUT socket option. Allow the connect timeout to be set either in the config: [tbon] connect_timeout = "10s" or on the broker command line: -Stbon.connect_timeout=10s The broker command line takes precedence. Set a default of 30s instead of the system default of "a long time" per zmq_setsockopt(3). Fixes flux-framework#5134
Problem: there is no test coverage for the tbon.connect_timeout broker attribute/config parameter. Add tests to t0013-config-file.t.
Problem: the tbon.connect_timeout broker attribute is undocumented. Add it to the man page.
Problem: the tbon.connect_timeout config parameter is not documented. Add it to the man page.
Problem: overlay_parse_timeout() checks the duration result from fsd_parse_duration() for <= 0 but fsd_parse_duration() cannot return a value less than zero, and zero itself is documented as "use system default". Remove the check for <= 0.
Problem: no tests show that tbon.connect_timeout can be set to 0, which means "use the system default". Add tests.
Codecov Report
@@ Coverage Diff @@
## master #5140 +/- ##
==========================================
+ Coverage 83.10% 83.12% +0.01%
==========================================
Files 453 453
Lines 77742 77750 +8
==========================================
+ Hits 64608 64630 +22
+ Misses 13134 13120 -14
|
|
Holy cow that was so fast! Will this go into 0.50.0? |
|
Yes, it made it in. Github actions is being slow so 0.50.0 is delayed until tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: there is no way to tune the ZMQ_CONNECT_TIMEOUT socket option.
Allow the connect timeout to be set either in the config:
or on the broker command line:
-Stbon.connect_timeout=10s.The broker command line takes precedence.
Set a default of 30s instead of the system default of "a long time" per zmq_setsockopt(3).
Fixes #5134