make SchedResourceList optional in flux.job.info #5141
Conversation
|
@grondo @garlick this is fully working! I think if we want to release older versions of flux for flux-python I can do some custom and manual work to make that happen (it's basically backporting this change, at least I just tested with 0.48.0 and it worked on corona) but if we can get this into a release, it should allow us to build python bindings from here on out. Tomorrow let's chat about if you want me to do the backported releases - my thinking is that before we do the official ones (because you can't undo/redo a release on pypi) we should do the following:
When those two things are done (it's working for the user and we have tests) I'll be comfortable doing "final" releases for older versions (with the manual work) and then I'll finish up the automated workflow for new releases. It's already written but I need to turn it on. |
|
Thanks! And let me know when you want to discuss the plan above - likely y’all can do the release work first and come back to it. I’m planning on rebuilding my flux images with this new release too. |
Problem: We currently cannot package rlist.h with the install (at least without more work) and since this is a required import for flux.job.info, without it the Python bindings (installed via pip) will error. Solution: the flux.resource module is not technically required, so we can fallback to catching the ImportError instead and using the same empty (dummy) class to handle self.resources Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
refactor/flux-resource-make-optional
branch
from
9d00bd9
to
ed8b0ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #5141 +/- ##
=======================================
Coverage 83.11% 83.11%
=======================================
Files 453 453
Lines 77750 77745 -5
=======================================
- Hits 64625 64621 -4
+ Misses 13125 13124 -1
|
Problem: We currently cannot package rlist.h with the install (at least without more work) and since this is a required import for flux.job.info, without it the Python bindings (installed via pip) will error.
Solution: the flux.resource module is not technically required, so we can fallback to catching the ImportError instead and using the same empty (dummy) class to handle self.resources
I am going to test this with the Python bindings, and would like to get that working first before we finalize it here! Note that I'm going to be taking a break for a few minutes but I'll be back after. I'll update the issue after I have done some testing with this branch!