Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job-list: misc cleanup #5144

Merged
merged 8 commits into from May 7, 2023
Merged

job-list: misc cleanup #5144

merged 8 commits into from May 7, 2023

Commits on May 5, 2023

  1. job-list: remove list_inactive_cb prototype 

    Problem: The function list_inactive_cb() was removed a long
time ago but the prototype for it is still in list.h.

Remove the function prototype.
    @chu11
    chu11 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    3823569 View commit details
    Browse the repository at this point in the history

  2. job-list: clarify comment 

    Problem: There is a comment describing job list filtering with the
'since' filtering.  The comment is a little confusing because it does
not match the code, doesn't describe how a list is sorted, and happens
to use the word "since" in the description.

Clarify the comment with more details.
    @chu11
    chu11 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    628220b View commit details
    Browse the repository at this point in the history

  3. flux-job: fix invalid tabbing 

    Problem: Some tabbing was incorrect.

Make tabbing good!
    @chu11
    chu11 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    e353520 View commit details
    Browse the repository at this point in the history

  4. doc: clarify --since in flux-jobs(1) 

    Problem: The wording in the --since option in flux-jobs(1) is a bit
misleading, suggesting that the --since option may apply only to
completed/inactive jobs.

Solution: Note that the --since option applies to jobs that were
active after the given timestamp, which makes it clear that --since
also will list pending and running jobs.
    @chu11
    chu11 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    c730f0a View commit details
    Browse the repository at this point in the history

  5. testsuite: fix invalid option in test 

    Problem: In a test in t2800-jobs-cmd.t, both the --filter and
--all option are specified, leading to unexpected output.  The
test happens to pass, but may not behave as intended.

Remove the -a option in the test.
    @chu11
    chu11 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    c60a2eb View commit details
    Browse the repository at this point in the history

  6. testsuite: update out of date comment 

    Problem: A comment in t2260-job-list.t is out of date.  flux_job_list()
has been deprecated and is no longer used.

Update the comment.
    @chu11
    chu11 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    8fbd157 View commit details
    Browse the repository at this point in the history

  7. testsuite: add job-archive active job test 

    Problem: The t2250-job-archive.t test does not test that active
jobs are not incorrectly archived in the archive database.

Add an additional test to double check for this.
    @chu11
    chu11 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    976b089 View commit details
    Browse the repository at this point in the history

  8. python: remove "all" filter name in add_filter() 

    Problem: The JobList class's add_filter() function checks for the
special filter name "all" and sets the filter to pending and running.
As far as I can tell, the special filter name "all" has never been
supported or documented.  In addition, it doesn't make much sense
since it should set pending, running, and inactive to get all jobs.
My suspicion is this may be left over code from development that
did not get removed.

Remove check for the filter name "all".
    @chu11
    chu11 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    d0597ee View commit details
    Browse the repository at this point in the history