pre-commit: increase vermin version #5173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: vermin did not detect some "obvious" version incompatability issues. Update the pre-commit check version of vermin from 1.4.2 to 1.5.1.
grondo
approved these changes
May 16, 2023
src/bindings/python/flux/util.py
Outdated
| @@ -30,8 +30,10 @@ | |||
|
|
|||
| import yaml | |||
|
|
|||
| # tomllib added to standard library in Python 3.10 | |||
There was a problem hiding this comment.
Suggested change
| # tomllib added to standard library in Python 3.10 | |
| # tomllib added to standard library in Python 3.11 |
There was a problem hiding this comment.
yeah, i got conflicting information about 3.10 vs 3.11. Seems we got it wrong in this prior commit too :-( 6298a36. But googling it does seem it is 3.11.
Problem: tomllib is included on Python 3.11 and newer versions and is loaded when available. This can cause a vermin check failure because the minimum required version for flux-core is 3.6. Add a "novermin" comment to pass the vermin check. Add a small comment to explain code as well.
chu11
force-pushed
the
vermin_version_update
branch
from
723be9a
to
3b9b6e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #5173 +/- ##
==========================================
- Coverage 83.12% 83.10% -0.02%
==========================================
Files 453 453
Lines 77856 77856
==========================================
- Hits 64717 64705 -12
- Misses 13139 13151 +12
|
|
thanks, setting MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5055 some code that was only supported in Python 3.11 did not get caught by the vermin check, which surprised me. It ended up it was caught in a newer version of vermin.
So lets increase the version and add a
novermincomment for one place that needs it. Also add a comment to the place that needs the novermin override.