Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: remove flux spack docker #5628

Merged
merged 1 commit into from Dec 19, 2023

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Dec 18, 2023

Problem: the flux + spack docker images in /etc are not commonly used and would better be maintained elsewhere anyway.
Solution: delete them from this repository (and will put elsewhere).

This will close #4962

Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vsoch
Copy link
Member Author

vsoch commented Dec 18, 2023

I'll have another repository to link here (soon) for folks that coming looking for these builds.

Ah yes, and this is totally intentional! 222!
image

@vsoch
Copy link
Member Author

vsoch commented Dec 18, 2023

ok - going to put the previous assets here: https://github.com/rse-ops/flux-spack-docker

@vsoch
Copy link
Member Author

vsoch commented Dec 19, 2023

Also please see https://github.com/rse-ops/spack-flux-container where we have a bunch of spack container builds.

Problem: the flux + spack docker images in /etc are not commonly used
and would better be maintained elsewhere anyway.
Solution: delete them from this repository (and will put elsewhere)

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #5628 (96d51cd) into master (cc0115e) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5628      +/-   ##
==========================================
- Coverage   83.45%   83.44%   -0.02%     
==========================================
  Files         487      487              
  Lines       82847    82847              
==========================================
- Hits        69141    69132       -9     
- Misses      13706    13715       +9     

see 9 files with indirect coverage changes

@mergify mergify bot merged commit e05410d into flux-framework:master Dec 19, 2023
34 checks passed
@vsoch vsoch deleted the remove-spack-docker branch December 19, 2023 01:53
@vsoch
Copy link
Member Author

vsoch commented Dec 19, 2023

Thank you mergify bot. You work so hard. 🍪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build issue with new merge for ubuntu container
2 participants