python: support Python 3.12 #5691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Building flux-core with Python 3.12 results in some SyntaxError warnings about invalid escape sequences. Use raw strings where necessary to avoid the warnings. Fixes flux-framework#5674 Co-authored-by: vsoch <vsoch@users.noreply.github.com>
Problem: Man pages are not rebuilt when doc/manpages.py is edited. Add manpages.py to the prerequesites for MAN_FILES in the Makefile.
Problem: The python/t0012-future.py test uses assertDictContainsSubset which has been deprecated for awhile and was removed in Python 3.12. Update the test to use a custom is_subset() function instead of unittest's assertDictContainsSubset().
|
Thank you! |
|
Thanks! I've set MWP. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5691 +/- ##
===========================================
- Coverage 83.46% 55.44% -28.02%
===========================================
Files 485 438 -47
Lines 82885 75286 -7599
===========================================
- Hits 69177 41744 -27433
- Misses 13708 33542 +19834 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few minor fixes required for Python 3.12 as identified by @vsoch, plus a test failure under the same (discovered in the conda-forge build)