-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps/docker: add 'time' as a dependency for tests #5933
deps/docker: add 'time' as a dependency for tests #5933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you adding a test requiring /usr/bin/time
in flux-core? If not, any reason this shouldn't go in the flux-sched Dockerfiles like the other flux-sched specific deps?
Anyway, it is pretty trivial so probably no reason to not include it here, since it might be surprising that it is missing..
Did you already rebuild and push up the affected fluxrm/testenv
images?b
Thanks!
I have not pushed them yet, and no it wasn't in core, honestly the thought was more "why on earth would time not work in eval?!?" since I would expect the bash builtin to work even if it wasn't there. Having tripped over it now 3 or 4 times I guessed others might and it was cheap enough to fix. If you're happy with this I'll start the run to push up the new testenv images momentarily, just give me an ACK. |
Hm, actually, since I'm in here, should I update the fedora dockerfile too? We're currently running 38 I think when current is 40, and 40 needs this same tweak (it's what I'm running on my dev VM). |
Feel free to update to fedora40 though that process is usually a bit time consuming if you want to hold off. |
problem: Apparently bookworm, jammy, focal, and new fedoras don't install /usr/bin/time by default. I ran into this trying to include time output in a test. solution: install it, added to each of the docker files as well as the install-deps-*.sh files.
8604445
to
1d749bb
Compare
Ok, added time to fedora39 so when that gets updated we don't have to remember. Waiting for the last two aarch64 container builds to finish (emulated, so they're kinda slow), as soon as that happens and they're cleanly posted I'll MWP this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5933 +/- ##
==========================================
- Coverage 83.38% 83.36% -0.02%
==========================================
Files 514 514
Lines 83055 83055
==========================================
- Hits 69253 69240 -13
- Misses 13802 13815 +13 |
problem: Apparently bookworm, jammy, focal, and new fedoras don't install /usr/bin/time by default. I ran into this trying to include time output in a test.
Evidently the "time" builtin in bash is suppressed inside the scope of an eval like we use in sharness, either way this seems less annoying than having to avoid it.
solution: install it, added to each of the docker files as well as the install-deps-*.sh files.