flux-job: add flux job taskmap --to=hosts
#5941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll set MWP. |
Problem: A couple static functions in job/taskmap.c use a flux_job* prefix, but this can be confusing because they are not part of the libflux API. Rename the functions to drop the flux_ prefix.
Problem: There are two functions in `flux job taskmap` that each open a separate flux handle. This is unnecessary. Remove the duplication by managing a global flux handle that is opened as needed.
Problem: It would be convenient to have a function to get the job hostlist in `flux job taskmap`, but currently that functionality is embedded in a function that translates nodeid to hostname. Split job_hostlist() out of job_nodeid_to_hostname().
Problem: It would be convenient to see the mapping of hostnames to taskids for a job all in one go, but `flux job taskmap` doesn't currently support that. Add a new output format `--to=hosts` to display a list of taskids for every host in a job.
Problem: When `flux job taskmap` options are used that require nodeid->hostname mapping, such as `--hostname` and `--to=hosts`, the R for a random jobid (or jobid 0 if id is initialized to 0) is fetched and a generic error is emitted: failed to get hostlist for job: No such file or directory Initialize `id` to FLUX_JOBID_ANY and issue an improved error message in these conditions, e.g. flux-job: taskmap: can't use --hostname without a jobid
Problem: There are no tests that exercise recent updates in the flux-job(1) taskmap subcommand, including the `--to=hosts` option and error handling when hostnames are required but not available. Update the t2616-job-shell-taskmap.t sharness test.
Problem: The --to=hosts option of the taskmap subcommand is not documented in flux-job(1). Add it to the documentation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5941 +/- ##
==========================================
+ Coverage 83.34% 83.38% +0.03%
==========================================
Files 514 514
Lines 83105 83134 +29
==========================================
+ Hits 69264 69318 +54
+ Misses 13841 13816 -25
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--to=hostsoption toflux job taskmap, which prints the hostname: tasks mapping for a job when given a jobid. E.g. for a 4 node 16 task "cyclic" job: