shell: add hwloc.restrict option to restrict HWLOC_XMLFILE to assigned resources
#5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grondo
force-pushed
the
hwloc.xmfile-restrict
branch
from
d1e25d3
to
3d44334
Compare
wihobbs
reviewed
May 6, 2024
doc/man1/flux-shell.rst
Outdated
| @@ -457,6 +457,12 @@ plugins include: | |||
| Note that this option will also unset ``HWLOC_COMPONENTS`` since presence | |||
| of this environment variable may cause hwloc to ignore ``HWLOC_XMLFILE``. | |||
|
|
|||
| .. option:: hwloc.xmlfile | |||
grondo
force-pushed
the
hwloc.xmfile-restrict
branch
from
3d44334
to
753a7f1
Compare
A bunch of warnings like this, but no impact to functionality as far as I can tell. Shows up on |
wihobbs
approved these changes
May 6, 2024
|
I'll go ahead and add MWP here as well. Thanks @wihobbs! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5944 +/- ##
==========================================
- Coverage 83.31% 83.31% -0.01%
==========================================
Files 515 515
Lines 83344 83352 +8
==========================================
+ Hits 69441 69442 +1
- Misses 13903 13910 +7
|
Problem: The HWLOC_XMLFILE provided by the hwloc.xmlfile job shell option is not restricted to the resources available to the job, but in some circumstances this would be useful. Add a hwloc.restrict option that, when used with hwloc.xmlfile, restricts the HWLOC_XMLFILE to the current process binding.
Problem: No test in the testsuite checks that the -o hwloc.restrict job shell option works. Add a test to t2619-job-shell-hwloc.t.
Problem: The `hwloc.restrict` job shell option is not documented. Document it in flux-shell(1) and the submission cli manpages.
grondo
force-pushed
the
hwloc.xmfile-restrict
branch
from
753a7f1
to
27204b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
hwloc.restrictjob shell option as described in #5934, along with a trivial test and docs.