do not filter caches when loading hwloc topology #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When loading hwloc topology, librlist applies the following
filter:
hwloc_topology_set_cache_types_filter(topo,
HWLOC_TYPE_FILTER_KEEP_STRUCTURE)
but this seems to remove L2/L3 caches on some systems. Removal of
these structures may have been useful in the past when the topology
wasn being gathered from every node into the KVS, but since this
is no longer done, this filter seems unnecessary and may reduce the
usefulness of some features like the job shell's `-o hwloc.xmlfile`
option.
Remove the hwloc cache types filter in librlist.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5945 +/- ##
=======================================
Coverage 83.31% 83.32%
=======================================
Files 515 515
Lines 83344 83343 -1
=======================================
+ Hits 69441 69446 +5
+ Misses 13903 13897 -6
|
wihobbs
approved these changes
May 6, 2024
|
Thanks I'll set MWP on this one since we implicitly have @trws's ACK as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5934, this PR removes the lines from librlist that are currently filtering out L2/L3/etc caches in the hwloc topology loaded by flux, thus making this information unavailable to components and processes that use this topology, since it is shared from parent to child instance and shell to shell plugin.