job-manager: journal jobspec with submit event #5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: job-list logs "update_jobspec: job xxx received jobspec update before jobspec" when flux-accounting sets a default bank. The job manager journal attached the jobspec to the validate event, so it is not available when jobspec-update events are sent before validate. Send it with submit instead of validate. Adjust job-list to handle it with the submit event. Fixes flux-framework#5951
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5955 +/- ##
==========================================
- Coverage 83.30% 83.29% -0.02%
==========================================
Files 515 515
Lines 83396 83396
==========================================
- Hits 69475 69464 -11
- Misses 13921 13932 +11
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: job-list logs "update_jobspec: job xxx received jobspec update before jobspec" when flux-accounting sets a default bank.
The job manager journal attached the jobspec to the validate event, so it is not available when jobspec-update events are sent before validate.
Send it with submit instead of validate. Adjust job-list to handle it with the submit event.
Fixes #5951