job-exec: do not allow guest access to the testexec implementation by default #5961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A couple sharness tests in the testsuite require guest access to the job-exec testexec implementation, but access will soon be denied to guests by default. Configure test instances to allow guest access to testexec where necessary.
Problem: Guest users can currently activate the job-exec test execution implementation, which is meant for testing and does not support job timelimits and isn't fully vetted for production use. Deny guests access to the testexec implementation by default. To allow guest access for testing purposes, add a new config config boolean `exec.testexec.allow-guests` which can be set in configuration to optionally allow guest access.
Problem: No tests ensure that the job-exec testexec implementation blocks use by guest users by default, but that this access can be restored via configuration. Add tests to t2400-job-exec-test.t that validate guest access to testexec.
Problem: The exec.testexec.allow-guests key is not documented in flux-config-exec(5). Add it. Update spelling dictionary.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5961 +/- ##
=======================================
Coverage 83.30% 83.31%
=======================================
Files 515 515
Lines 83396 83401 +5
=======================================
+ Hits 69477 69483 +6
+ Misses 13919 13918 -1
|
garlick
approved these changes
May 13, 2024
|
Thanks, I'll propose a PR for flux-accounting. |
grondo
changed the title
|
Removed WIP and flux-accounting checks are now passing so I'll set MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables guest user access to the job-exec
testexecimplementation by default.Since multiuser testexec jobs are used in the flux-core and flux-accounting testsuites, a new configuration option is added to optionally allow it:
exec.testexec.allow-guests, which must be set totrue.flux-accounting tests will fail until
allow-guestsis set there. However, I was going to wait in case someone had a better idea of how to optionally allow this feature for testing.