Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/man1/flux-start.adoc: Fix example option usage #852

Merged
merged 1 commit into from Oct 13, 2016

Conversation

Projects
None yet
5 participants
@chu11
Copy link
Contributor

chu11 commented Oct 13, 2016

Noticed this didn't work:

$ src/cmd/flux start -s8 -o,log-stderr-level=7
log-stderr-level=7: Command not found.
2016-10-13T20:59:52.618549Z broker.err[0]: Run level 2 Exited with non-zero status (rc=1) 0.1s
flux-start: 0 (pid 53483) exited with rc=1

Which I got out of the manpage. I think it should be: -o,--setattr=log-stderr-level=7 now?

@garlick garlick added the review label Oct 13, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 13, 2016

Coverage Status

Coverage decreased (-0.04%) to 75.097% when pulling af30d07 on chu11:fixfluxstartmanpageexample into c65b665 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 13, 2016

Current coverage is 71.50% (diff: 100%)

Merging #852 into master will decrease coverage by 0.01%

@@             master       #852   diff @@
==========================================
  Files           157        157          
  Lines         26683      26688     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          19082      19082          
- Misses         7601       7606     +5   
  Partials          0          0          

Powered by Codecov. Last update 90f1cb3...af30d07

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 13, 2016

Looks good.

We just merged pr #849 so would you mind rebasing to keep the history linear?

@chu11 chu11 force-pushed the chu11:fixfluxstartmanpageexample branch from af30d07 to 6b28c92 Oct 13, 2016

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 13, 2016

sure thing, rebased it's now running through travis again

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 13, 2016

Thanks! Merging, not much point in waiting for travis.

@garlick garlick merged commit fdea053 into flux-framework:master Oct 13, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@garlick garlick removed the review label Oct 13, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 13, 2016

Coverage Status

Coverage decreased (-0.004%) to 75.132% when pulling 6b28c92 on chu11:fixfluxstartmanpageexample into 90f1cb3 on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 14, 2016

Just fyi, noticed there is now a rebase and merge selection under the
github merge button for this kind of thing

On Oct 13, 2016 4:18 PM, "Coveralls" notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/8330209

Coverage decreased (-0.004%) to 75.132% when pulling 6b28c92
6b28c92
on chu11:fixfluxstartmanpageexample
into 90f1cb3
90f1cb3
on flux-framework:master
.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#852 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtSUlwIFTQim7Ywmm1uiGY8Zj0oQ02wks5qzrw0gaJpZM4KWYI5
.

@garlick garlick referenced this pull request Oct 26, 2016

Closed

0.5.0 release notes #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.