Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: add note about clock synchronization #246

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

garlick
Copy link
Member

@garlick garlick commented Jul 19, 2023

Problem: Flux requires local clocks to be synchronized across the cluster, but this is not mentioned in the Admin Guide.

For example

  • job-ingest sets t_submit to the local time
  • flux_job_timeleft() returns expiration relative to the local time
  • Flux logs are time stamped at origin

Add a note to the section on prerequisites.

Problem: Flux requires local clocks to be synchronized across
the cluster, but this is not mentioned in the Admin Guide.

For example
- job-ingest sets `t_submit` to the local time
- flux_job_timeleft() returns expiration relative to the local time
- Flux logs are time stamped at origin

Add a note to the section on prerequisites.
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@garlick
Copy link
Member Author

garlick commented Jul 19, 2023

Drat:

Initializing Spelling Checker 8.0.0
Could not import `keymap_db` module from `pymdownx` package.
    Please ensure `pymdown-extensions` is installed.
    The `:keys:` role has no default key map.

@garlick garlick added the merge-when-passing mark PR for auto-merging by mergify.io bot label Jul 19, 2023
@grondo
Copy link
Contributor

grondo commented Jul 19, 2023

Hm, maybe need to pin some dependency in requirements.txt?

@vsoch
Copy link
Member

vsoch commented Jul 19, 2023

Oh I've seen this: sphinx-doc/sphinx#11479. Resolution at the last comment!

For passersby, this is a duplicate of jbms/sphinx-immaterial#268 which was resolved and released in sphinx-immaterial v0.11.5.

@garlick
Copy link
Member Author

garlick commented Jul 19, 2023

Thanks @vsoch! Hmm, except now I get

ERROR: Ignored the following versions that require a different python version: 0.11.1 Requires-Python >=3.8; 0.11.2 Requires-Python >=3.8; 0.11.3 Requires-Python >=3.8; 0.11.4 Requires-Python >=3.8; 0.11.5 Requires-Python >=3.8
ERROR: Could not find a version that satisfies the requirement sphinx-immaterial>=0.11.5 (from versions: 0.1, 0.2, 0.3, 0.3.1, 0.4.0, 0.4.1, 0.5.0, 0.6.0, 0.6.1, 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.8.0, 0.8.1, 0.9.0, 0.9.1, 0.10.0, 0.11.0)
ERROR: No matching distribution found for sphinx-immaterial>=0.11.5

@vsoch
Copy link
Member

vsoch commented Jul 19, 2023

I didn’t test that suggested fix (we should let them know) but instead I pinned pydantic: https://github.com/flux-framework/flux-operator/blob/59bfeab688588d89242c9d4d7f9645204d20876c/docs/requirements.txt

Problem: readthedocs build fails with

Could not import `keymap_db` module from `pymdownx` package.
    Please ensure `pymdown-extensions` is installed.
    The `:keys:` role has no default key map.

Pin pydantic==1.10.8 as suggested by @vsoch.
@mergify mergify bot merged commit 0e76136 into flux-framework:master Jul 19, 2023
7 checks passed
@vsoch
Copy link
Member

vsoch commented Jul 19, 2023

Noice! 🙌

@garlick
Copy link
Member Author

garlick commented Jul 19, 2023

That worked! Oof I had forgotten I had set MWP earlier so - it's merged!

Many thanks @vsoch! I really did not want to dig into that.

@vsoch
Copy link
Member

vsoch commented Jul 19, 2023

Many thanks @vsoch! I really did not want to dig into that.

Always really glad when I can help. <3

@garlick garlick deleted the admin_time branch July 20, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mark PR for auto-merging by mergify.io bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants