-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canopie22 artifacts for reproducibility of our work #31
Canopie22 artifacts for reproducibility of our work #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That all looks good to me
Thanks @cmisale! I'm going to update a few things and then we can merge it soon. |
Only 45K lines of yaml! 😆 😭 Are there instructions for how to use the containers outside of the MPI operator (maybe a TODO for a separate repository with very basic examples of running flux?) (understanding that this repository is scoped to reproduce your paper work!) |
After a bit more thought those build and run instructions (which I still need to write) are better for the MPI Operator repo. I'll get a PR ready for that. |
3a92dcb
to
72c10df
Compare
@cmisale: how should we go about replacing |
Just be careful with the .git directory for doing it on the command line - I have broke many a git directory with this kind of substitution! If you have VSCode they have a nice find and replace that will show you the places before doing it. |
72c10df
to
dbed6ab
Compare
Excellent point; noted. |
I was about to say yes, but just considered something. All the data that I put in this PR references "KubeFlux". Should I leave the references in the data? If so, plotting (and job management, eventually) will need to change, too. For example, in the Python plotting scripts, we have: sns.boxplot(
x="ranks",
y="real",
hue="scheduler",
data=df,
whis=[5, 95],
palette={"default-scheduler": "#4878d0", "kubeflux": "#ee854a"},
)
|
I think a simple check in the plotting scripts to check for |
dbed6ab
to
1af30be
Compare
Ok, I've cleaned up the plotting scripts and ensured they work. @cmisale go ahead and make the two changes you mentioned above. |
@milroy sounds good! I should be able to complete it by today |
Pretty name showing up
|
Thank you @cmisale! I added a fixup commit with the changes to the repo. I'll test the combined changes on EKS ASAP and let you know what happens. |
It works: Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Normal Scheduled 14s fluence Successfully assigned default/lammps-4661ea379f0b-worker-0 to ip-192-168-41-26.us-east-2.compute.internal
Normal Pulling 14s kubelet Pulling image "milroy1/kf-testing:lammps-focal-openmpi-4.1.2-amd-efa"
Normal Pulled 13s kubelet Successfully pulled image "milroy1/kf-testing:lammps-focal-openmpi-4.1.2-amd-efa" in 275.853816ms
Normal Created 13s kubelet Created container worker
Normal Started 13s kubelet Started container worker
|
287e7fb
to
4820b56
Compare
4820b56
to
a882d45
Compare
I'm merging this PR. Thank you very much @cmisale! |
Great!! |
YAMLs, dockerfiles, Python scripts, JSONs and output data necessary to reproduce our CANOPIE 2022 paper: One Step Closer to Converged Computing: Achieving Scalability with Cloud-Native HPC.