Fix for reading hwloc xml files generated from Sierra compute nodes #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add @TWRS' patch. Need this on the hwloc generated from LLNL's Sierra machine. hwloc-ls --version reports 1.11.2
Generate and add xml files using lstopo on 4 Sierra compute nodes. Run a smoke test to validate that `resrc` likes the format.
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 74.11% 74.12% +<.01%
==========================================
Files 49 49
Lines 9287 9290 +3
==========================================
+ Hits 6883 6886 +3
Misses 2404 2404
Continue to review full report at Codecov.
|
|
No I don't. But I think this can go in first now that it looks like i will have to fix a CI failure on the other PR... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion at #308:
Incorporate @trws' patch to handle group type.
Add a test case using hwloc xml files collected from Sierra nodes.