Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: use explicit duration units #966

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

garlick
Copy link
Member

@garlick garlick commented Sep 12, 2022

Problem: flux mini will fail when small durations are specified without units after flux-framework/flux-core#4565.

Add explicit units to flux mini CMD -t where necessary.

Problem: flux mini will fail when small durations are
specified without units after flux-framework/flux-core#4565.

Add explicit units to flux mini CMD -t where necessary.
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@garlick garlick added the merge-when-passing mergify.io - merge PR automatically once CI passes label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #966 (14113eb) into master (abd7fcf) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #966   +/-   ##
======================================
  Coverage    74.0%   74.0%           
======================================
  Files          78      78           
  Lines        9291    9291           
======================================
  Hits         6882    6882           
  Misses       2409    2409           

@mergify mergify bot merged commit 69d4061 into flux-framework:master Sep 12, 2022
@garlick garlick deleted the duration_units branch October 5, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mergify.io - merge PR automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants